This repository has been archived by the owner on Nov 4, 2023. It is now read-only.
Greeter orientation #402
Merged
Greeter orientation #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
capsia37
force-pushed
the
xenial_-_greeter-orientation
branch
from
b21c8ef to
43a8e9f
Compare
capsia37
force-pushed
the
xenial_-_greeter-orientation
branch
from
43a8e9f to
49382ef
Compare
capsia37
force-pushed
the
xenial_-_greeter-orientation
branch
from
49382ef to
61676a0
Compare
|
@capsia37 can you get this ready in lets say 2 weeks so we can include it in OTA-21? |
capsia37
force-pushed
the
xenial_-_greeter-orientation
branch
from
61676a0 to
21ccf43
Compare
Sure, I'll do my best! |
|
Also here friendly reminder, create an issue and link the PR to it :) |
capsia37
force-pushed
the
xenial_-_greeter-orientation
branch
from
89ef1e6 to
cb724dd
Compare
|
Solves #419 |
Closed
capsia37
force-pushed
the
xenial_-_greeter-orientation
branch
from
0d08925 to
4056f51
Compare
Flohack74
approved these changes
Jan 15, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enables greeter rotation and is based on #401 and #315 .
It includes:
Possible future improvements:
We might want the CoverPage to show only when the user locked the account. When the device boots up for the first time or the user chooses to logout, the user would usually want to login again, so we should hide the CoverPage. When the device is locked after a certain time or the user decides to lock it, it should show the cover page.
Screenshots (on Nexus 5):
